vcs: Scope parameter assignments to toplevel module#510
Merged
olofk merged 2 commits intoolofk:mainfrom Mar 24, 2026
Merged
Conversation
Parameter assignments in parameters.txt need to be qualified with the toplevel module name to work correctly with VCS simulation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assign <value> <param>inparameters.txtapplies to every parameter in the design hierarchy that shares the same name, not just the toplevel instance. This causes unintended parameter overrides deep in the hierarchy.self.toplevel.so assignments are properly scoped to the toplevel module only (e.g.,assign "value" top.PARAMinstead ofassign "value" PARAM).Test plan
parameters.txtcontains toplevel-qualified parameter names🤖 Generated with Claude Code